Change in vdsm[master]: jsonrpc: provide more info when method not found

nsoffer at redhat.com nsoffer at redhat.com
Sat Feb 27 21:30:33 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: jsonrpc: provide more info when method not found
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/53714/3/tests/integration/jsonRpcTests.py
File tests/integration/jsonRpcTests.py:

Line 148: 
Line 149:                     self.assertEquals(
Line 150:                         cm.exception.code,
Line 151:                         JsonRpcMethodNotFoundError(missing_method).code)
Line 152:                     self.assertTrue(missing_method in cm.exception.message)
Better use assertIn() - we will get better error message on failures.
Line 153: 
Line 154:     @permutations(PERMUTATIONS)
Line 155:     def testMethodBadParameters(self, ssl, type):
Line 156:         # Without a schema the server returns an internal error


-- 
To view, visit https://gerrit.ovirt.org/53714
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib29240f002ab7c11744d164cf4e0ea5f47924929
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list