Change in vdsm[master]: virt: extract destroyVm helper

danken at redhat.com danken at redhat.com
Fri Feb 26 15:49:15 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: virt: extract destroyVm helper
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/53932/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3878:                     self.id, e.get_error_code())
Line 3879:                 if e.get_error_code() == libvirt.VIR_ERR_OPERATION_FAILED:
Line 3880:                     retry = True
Line 3881:                 return response.error('destroyErr'), retry
Line 3882:         return response.success(), retry
why do we two return values? as far as I see

  retry == not success
Line 3883: 
Line 3884:     def _destroyVmForceful(self):
Line 3885:         try:
Line 3886:             self._dom.destroy()


-- 
To view, visit https://gerrit.ovirt.org/53932
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id152a7aae3d4f644f34703f7f0b5f98035e4e295
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list