Change in vdsm[master]: net: ifcfg: rollback nicless bridge

danken at redhat.com danken at redhat.com
Fri Feb 26 15:18:12 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: ifcfg: rollback nicless bridge
......................................................................


net: ifcfg: rollback nicless bridge

Ifcfg rollback is not able to rollback simple nicless bridge. We do
the removal of interfaces just with ifdown during the rollback. For
some reason this is enough for vlaned networks, but not for
a just-a-bridge network.

We fixed that with explicit delbr of to-be-rolled-back bridges.

Because of we don't guarantee handling order in networks setup, this
cannot be simply tested - we cannot create a test where nicless
network is set up and then another network setup fails.

This patch was tested manually. In a following patch, explicit removal
of networks will be removed from _check_connectivity() and therefore
testSetupNetworksConnectivityCheck() will work as a test for this
scenario.

Change-Id: Ic0cd62806fe10e288cc6183a554b52d97883bc82
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/54069
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/54069
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0cd62806fe10e288cc6183a554b52d97883bc82
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list