Change in vdsm[master]: ipwrapper: unbreak oper_up

danken at redhat.com danken at redhat.com
Thu Feb 25 19:45:43 UTC 2016


Dan Kenigsberg has uploaded a new change for review.

Change subject: ipwrapper: unbreak oper_up
......................................................................

ipwrapper: unbreak oper_up

commit 65636d51 removed ipwrapper.Link.flags, but left behind a method
using it.

Fix the glitch and have the method tested.

Change-Id: Icd3b1837df9e5ae3f60814df1b912b5768c736e3
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/ipwrapper.py
M tests/network/ipwrapper_test.py
2 files changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/54054/1

diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index fb61916..499fa42 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -225,7 +225,7 @@
 
     @property
     def oper_up(self):
-        return bool(self.flags & self.IFF_RUNNING)
+        return bool(link.get_link(self.name)['flags'] & self.IFF_RUNNING)
 
     def get_promisc(self):
         return bool(link.get_link(self.name)['flags'] & self.IFF_PROMISC)
diff --git a/tests/network/ipwrapper_test.py b/tests/network/ipwrapper_test.py
index 6499de0..4353d25 100644
--- a/tests/network/ipwrapper_test.py
+++ b/tests/network/ipwrapper_test.py
@@ -109,6 +109,7 @@
     def testGetLink(self):
         link = ipwrapper.getLink(self._bridge.devName)
         self.assertTrue(link.isBRIDGE)
+        self.assertTrue(link.oper_up)
         self.assertEqual(link.master, None)
         self.assertEqual(link.name, self._bridge.devName)
 


-- 
To view, visit https://gerrit.ovirt.org/54054
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd3b1837df9e5ae3f60814df1b912b5768c736e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list