Change in vdsm[master]: net: api: fix invalid refactoring

danken at redhat.com danken at redhat.com
Thu Feb 25 15:22:27 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: api: fix invalid refactoring
......................................................................


net: api: fix invalid refactoring

else branch used to iterate 'nics' and if there was none, it just did
nothing.

During the refactoring [1] we get rid of 'nics' and replaced it with
'nic'. In case when 'bonding' is None, we go to else branch and
without any checking call _validateInterNetworkCompatibility()
which fails for None nic.

[1] https://gerrit.ovirt.org/#/c/53475/15/lib/vdsm/network/api.py

Change-Id: I7f5ecd7682b05da4970930656b4f18c0f67b4180
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/54016
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas <edwardh at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/network/api.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/54016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7f5ecd7682b05da4970930656b4f18c0f67b4180
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list