Change in vdsm[master]: virt: adding virt basic api module to supervdsm

ybronhei at redhat.com ybronhei at redhat.com
Thu Feb 25 08:46:56 UTC 2016


Yaniv Bronhaim has posted comments on this change.

Change subject: virt: adding virt basic api module to supervdsm
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

thanks!

https://gerrit.ovirt.org/#/c/54004/1/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 75: from storage.fileUtils import chown, resolveGid, resolveUid
Line 76: from storage.fileUtils import validateAccess as _validateAccess
Line 77: from vdsm.constants import METADATA_GROUP, EXT_CHOWN, \
Line 78:     DISKIMAGE_USER, DISKIMAGE_GROUP, \
Line 79:     P_LIBVIRT_VMCHANNELS, P_OVIRT_VMCONSOLES, \
16:14:55 vdsm/supervdsmServer:23: 'stat' imported but unused
16:14:55 vdsm/supervdsmServer:77: 'P_LIBVIRT_VMCHANNELS' imported but unused
16:14:55 vdsm/supervdsmServer:77: 'P_OVIRT_VMCONSOLES' imported but unused
Line 80:     VDSM_USER, QEMU_PROCESS_USER, QEMU_PROCESS_GROUP, GLUSTER_MGMT_ENABLED
Line 81: from storage.devicemapper import _removeMapping, _getPathsStatus
Line 82: from vdsm.config import config
Line 83: import mkimage


-- 
To view, visit https://gerrit.ovirt.org/54004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9acf5a2f8fd14ac172bb6ea70b8888bc2aff8caf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list