Change in vdsm[master]: net: api: refactoring of _handleBondings

edwardh at redhat.com edwardh at redhat.com
Wed Feb 24 21:36:19 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: api: refactoring of _handleBondings
......................................................................


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/53695/15/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 583: _valid_bond_removal
> the name is a bit off. I think that _bond_is_valid_for_removal() or _bond_i
Funcs that return with a bool usually start (if possible) with is_*.
So _is_bond_valid_for_removal() is nicer.

But it is a nit, keeping my +1 :)


-- 
To view, visit https://gerrit.ovirt.org/53695
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02e34470a39f84ada0246cf35e12c52990ed7134
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list