Change in vdsm[master]: net: api: move netinfo update and save one call

danken at redhat.com danken at redhat.com
Wed Feb 24 18:07:05 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net: api: move netinfo update and save one call
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/53760/2/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 685
Line 686
Line 687
Line 688
Line 689
how costly is this call?

I would really prefer to keep _netinfo up-to-date, even though the current caller of this function does not use it.

Frankly, I suspect that this change is a premature optimization that distracts us from our main goal (simplifying setupNetworks() and splitting it apart)


-- 
To view, visit https://gerrit.ovirt.org/53760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4dd7572986ffee5a2060470d904116d04e80c97
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list