Change in vdsm[master]: virt: rng: Rng device should not depend on caps.py

mpolednik at redhat.com mpolednik at redhat.com
Wed Feb 24 12:07:33 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: virt: rng: Rng device should not depend on caps.py
......................................................................


Patch Set 1:

There is something I don't like about the staticmethod names, let me think about it a bit more. Other then that, I like the approach as the functionality is closely tied to the device. Consider this +1 on hold.

-- 
To view, visit https://gerrit.ovirt.org/53558
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If74f6c262f6a0bd4ed6a968e17e883e1e264ed54
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list