Change in vdsm[master]: repoplot: Optimize log parsing

ykaul at redhat.com ykaul at redhat.com
Wed Feb 24 09:50:41 UTC 2016


Yaniv Kaul has posted comments on this change.

Change subject: repoplot: Optimize log parsing
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/53949/2/contrib/repoplot
File contrib/repoplot:

Line 82:     Parse repoStat from vdsm log. Return dict of DomainStats objects.
Line 83:     """
Line 84:     stats = defaultdict(DomainStats)
Line 85: 
Line 86:     for line in fileinput.input(files):
Perhaps set a buffer? See https://hg.python.org/cpython/file/2.7/Lib/fileinput.py#l67
Line 87:         pos = line.find(REPOSTAT)
Line 88:         if pos == -1:
Line 89:             continue
Line 90:         timestamp = line.split("::", 3)[2]


-- 
To view, visit https://gerrit.ovirt.org/53949
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac2b2e675d1c4397a5659e89a34689ce7e4004a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list