Change in vdsm[master]: migration: Add retry on full capacity
fromani at redhat.com
fromani at redhat.com
Tue Feb 23 15:24:56 UTC 2016
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
......................................................................
Patch Set 14: Code-Review-1
(3 comments)
mostly OK, but:
1. (MAJOR) we should review and test the saveState() change separately, to make sure it is correct
2. (MINOR) we need a nicer alternative to compare the error code
https://gerrit.ovirt.org/#/c/52799/14/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 29: from vdsm import vdscli
Line 30: from vdsm import jsonrpcvdscli
Line 31: from vdsm.compat import pickle
Line 32: from vdsm.config import config
Line 33: from vdsm.define import NORMAL, Mbytes, errCode
we should not use errCode anymore. See below please.
Line 34: from vdsm.sslcompat import sslutils
Line 35: from yajsonrpc import \
Line 36: JsonRpcNoResponseError, \
Line 37: JsonRpcBindingsError
Line 601: self._vm.log.debug('stopping migration monitor thread')
Line 602: self._stop.set()
Line 603:
Line 604:
Line 605: def is_retry_error(result):
let's figure out a nicer helper to be put in the response module
Line 606: return result['status']['code'] == \
https://gerrit.ovirt.org/#/c/52799/14/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 686: self._vmStartEvent.set()
Line 687: return
Line 688:
Line 689: self._vmStartEvent.set()
Line 690: self.saveState()
this important enough to deserve a separate patch, on which this one should depend on.
Line 691: try:
Line 692: self.memCommit()
Line 693: with self._ongoingCreations:
Line 694: self._vmCreationEvent.set()
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list