Change in vdsm[master]: net: api: refactoring of _handleBondings

edwardh at redhat.com edwardh at redhat.com
Tue Feb 23 15:00:56 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: api: refactoring of _handleBondings
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/53695/10/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 644: 
Line 645:     return True
Line 646: 
Line 647: 
Line 648: def _bond_setup(bondings, configurator, _netinfo):
> reasonable, but tha same as for line 655 comment. we can
Not sure what is the difference between option 2 and 3.
I think that the usage should guide us:

Instead of:
_bond_removal(bondings, configurator, _netinfo, in_rollback)
_bond_setup(bondings, configurator, _netinfo)

Proposing:

bonds_to_remove, bonds_to_edit, bonds_to_add = _bond_classification()
_bond_remove(bonds_to_remove)
_bond_edit(bonds_to_edit) # can we do here slave removal and regular edit?
_bond_add(bonds_to_add)

What do you think?
Line 649:     """Gather to-be-edited/added bondings and apply changes"""
Line 650:     _netinfo = CachingNetInfo()
Line 651: 
Line 652:     edition = {}


-- 
To view, visit https://gerrit.ovirt.org/53695
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02e34470a39f84ada0246cf35e12c52990ed7134
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list