Change in vdsm[master]: fix import error

phoracek at redhat.com phoracek at redhat.com
Tue Feb 23 13:31:01 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: fix import error
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/53901/2/init/wait_for_ipv4s
File init/wait_for_ipv4s:

Line 12: 
Line 13: from vdsm.netinfo.addresses import getIpInfo
Line 14: from vdsm.netlink import monitor
Line 15: from vdsm.network.configurators.ifcfg import NET_CONF_DIR
Line 16: from vdsm.network.configurators.ifcfg import ConfigWriter
why don't we keep it on one line?

BTW it was silently failing all that time?
Line 17: 
Line 18: 
Line 19: def _get_vdsm_ip_onboot_devs():
Line 20:     """Return set of VDSM devices with assigned IPv4 and ONBOOT=yes"""


-- 
To view, visit https://gerrit.ovirt.org/53901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5884052df7c6cb07d8322ab22f62657961352098
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list