Change in vdsm[master]: vmstats: from EAFP to LBYL

danken at redhat.com danken at redhat.com
Tue Feb 23 12:59:41 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vmstats: from EAFP to LBYL
......................................................................


vmstats: from EAFP to LBYL

libvirt bulk stats' API allows to return partial result.
Hence, seems better to Look Before You Leap in this flow,
instead of thinking that is Easier (to) Ask Forgiveness (than)
Permission.

As nice side effect, this patch removes spam from the logs.

Change-Id: I7383ff62e8c7e7923567b6d04942bb1e92aab84a
Bug-Url: https://bugzilla.redhat.com/1299480
Backport-To: 3.6
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/53613
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/virt/vmstats.py
1 file changed, 13 insertions(+), 8 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/53613
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7383ff62e8c7e7923567b6d04942bb1e92aab84a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list