Change in vdsm[master]: vmstats: from EAFP to LBYL

danken at redhat.com danken at redhat.com
Tue Feb 23 11:47:25 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: vmstats: from EAFP to LBYL
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/53613/7/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:

Line 125: make types uniform (e.g. all str)
cpuUsage should have the same type as cpuUser and cpuSys
we may block the str() when xmlrpc is deserted.


-- 
To view, visit https://gerrit.ovirt.org/53613
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7383ff62e8c7e7923567b6d04942bb1e92aab84a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list