Change in vdsm[ovirt-3.6.3]: Live Merge: Skip initial extension when base is raw

amureini at redhat.com amureini at redhat.com
Tue Feb 23 10:51:32 UTC 2016


Hello Nir Soffer, Adam Litke, Francesco Romani,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/53883

to review the following change.

Change subject: Live Merge: Skip initial extension when base is raw
......................................................................

Live Merge: Skip initial extension when base is raw

When starting a live merge we pre-extend the base volume in order to
accomodate the data that will be merged into the base volume.  This is
only necessary for thinly provisioned block volumes.  Check to make sure
that the base volume is eligible for extension before extending it.

Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3
Bug-Url: https://bugzilla.redhat.com/1301709
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/53318
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Continuous-Integration: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/53883/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 4111c2f..bb0c31c 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4891,7 +4891,7 @@
         # the worst case, the allocated size of 'base' should be increased by
         # the allocated size of 'top' plus one additional chunk to accomodate
         # additional writes to 'top' during the live merge operation.
-        if drive.chunked:
+        if drive.chunked and baseInfo['format'] == 'COW':
             capacity, alloc, physical = self._getExtendInfo(drive)
             baseSize = int(baseInfo['apparentsize'])
             topSize = int(topInfo['apparentsize'])


-- 
To view, visit https://gerrit.ovirt.org/53883
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If105854174e9fdbc9bad7aef511ff233de8991a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6.3
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list