Change in vdsm[master]: net: api: rename _add_missing_networks -> _net_setup

edwardh at redhat.com edwardh at redhat.com
Mon Feb 22 20:55:30 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: api: rename _add_missing_networks -> _net_setup
......................................................................


Patch Set 1:

Not sure if I understand. This func just adds a network, it uses several devices to build one.
A special case is when a bridge device already exists and it is reused, I wouldn't call it an edit exactly.
it's more like a lazy add, so lets keep it an add for now.

-- 
To view, visit https://gerrit.ovirt.org/53759
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia08261a4c998a05e16b275fb9cbb5a2386e1937f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list