Change in vdsm[ovirt-3.6.3]: tests: Fix loop device leak in mount tests

danken at redhat.com danken at redhat.com
Mon Feb 22 20:12:16 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: Fix loop device leak in mount tests
......................................................................


tests: Fix loop device leak in mount tests

We used to unmount loop devices without using force=True and
freeloop=True. This may lead to loop device leak, failing the later
tests trying to mount loop devices. We also did not wait for udev events
when unmounting a loop device, which is asynchronous operation.

Both issues were fixed long time ago (commit dbfdc90) in the mkimageTests.
Apply the same fix for mount tests.

Change-Id: Iada8f3d962778c53ada4a6f0a7f3e75b80c07239
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/51614
Continuous-Integration: Jenkins CI
Reviewed-by: Fabian Deutsch <fabiand at redhat.com>
Reviewed-by: Edward Haas <edwardh at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/53562
Reviewed-by: Francesco Romani <fromani at redhat.com>
Continuous-Integration: Dan Kenigsberg <danken at redhat.com>
Tested-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/mountTests.py
1 file changed, 11 insertions(+), 2 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/53562
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iada8f3d962778c53ada4a6f0a7f3e75b80c07239
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6.3
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list