Change in vdsm[ovirt-3.6]: net: Fix dhcp reporting

danken at redhat.com danken at redhat.com
Mon Feb 22 16:56:15 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net: Fix dhcp reporting
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/53827/1/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 452:     if net_attrs is None:
Line 453:         logging.debug('There is no VDSM network configured on %s.' % iface)
Line 454:         if not is_persistence_unified():
Line 455:             cfg = getIfaceCfg(iface)
Line 456:             return ((family == 4 and
I would personally find this more readable as 

 if family == 4:
  ...
 else:
  ... return some crazy initscript predicate
Line 457:                      cfg.get('BOOTPROTO', 'none') == 'dhcp') or
Line 458:                     (family == 6 and
Line 459:                      cfg.get('IPV6INIT', 'no') == 'yes' and
Line 460:                      cfg.get('BOOTPROTO', 'none') == 'dhcp') or


Line 459: no
initscripts' default for this is 'yes'.

Also, should you not make sure that DHCPV6C is not "no"?
Doesn't initscripts have a means to ask for dhcpv4 but not dhcpv6 yet keep ipv6 initialized?


-- 
To view, visit https://gerrit.ovirt.org/53827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7879ff488d26bc9993416b1af9635d5e882d9123
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list