Change in vdsm[master]: hostdev: add support for hotunplug

fromani at redhat.com fromani at redhat.com
Mon Feb 22 10:38:34 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: hostdev: add support for hotunplug
......................................................................


Patch Set 2:

(2 comments)

initial review

https://gerrit.ovirt.org/#/c/42747/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2076:         ret['success'] = True
Line 2077:         return ret
Line 2078: 
Line 2079:     def _hotunplugHostdevInternal(self, params):
Line 2080:         def create_dev_map():
let's have this below the self.isMigrating() check.
Line 2081:             dev_map = {}
Line 2082:             for dev_object in self._devices[hwclass.HOSTDEV]:
Line 2083:                 dev_map[dev_object.device] = dev_object
Line 2084: 


Line 2085:         if self.isMigrating():
Line 2086:             return errCode['migInProgress']
Line 2087: 
Line 2088:         ret = {'success': False,
Line 2089:                'modified_devices': []}
set() ?
Line 2090: 
Line 2091:         dev_names = params['devices']
Line 2092: 
Line 2093:         dev_map = create_dev_map()


-- 
To view, visit https://gerrit.ovirt.org/42747
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If36f7da8f018615b76a1a8779ff15b890a823db8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list