Change in vdsm[master]: net: also disable IPv6 on bridges not using it, after unifie...
osvoboda at redhat.com
osvoboda at redhat.com
Sun Feb 21 14:42:03 UTC 2016
Ondřej Svoboda has posted comments on this change.
Change subject: net: also disable IPv6 on bridges not using it, after unified restoration
......................................................................
Patch Set 6:
(3 comments)
needinfo :-)
https://gerrit.ovirt.org/#/c/53683/6/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 136: logging.debug('Calling setupNetworks with networks (%s) '
Line 137: 'and bond (%s).', nets, bonds)
Line 138: setupNetworks(nets, bonds, {'connectivityCheck': False,
Line 139: '_inRollback': True})
Line 140: if ipv6_supported():
> I would prefer to see this checked in the running vs kernel check and not h
Eddie, can you point me to the exact location, and explain your motivation? I am afraid I don't follow you.
Line 141: _restore_disable_ipv6(nets)
Line 142:
Line 143:
Line 144: def _verify_all_devices_are_up(owned_ifcfg_files):
Line 136: logging.debug('Calling setupNetworks with networks (%s) '
Line 137: 'and bond (%s).', nets, bonds)
Line 138: setupNetworks(nets, bonds, {'connectivityCheck': False,
Line 139: '_inRollback': True})
Line 140: if ipv6_supported():
> disabling ipv6 on pre-existing networks is not as useful as adding QoS on
I am lost in your comment too, Dan. What does KernelConfig do with IPv6, why is their relation special?
Line 141: _restore_disable_ipv6(nets)
Line 142:
Line 143:
Line 144: def _verify_all_devices_are_up(owned_ifcfg_files):
Line 356: networks.iteritems
> new code should be python3-compatible. please use
Oops, I forgot. I'll push this as soon as I understand your comments above.
--
To view, visit https://gerrit.ovirt.org/53683
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12be9d8c99ddfeb85d6ba6093535e35b6883e963
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list