Change in vdsm[master]: net: api: move netinfo update and save one call

edwardh at redhat.com edwardh at redhat.com
Sat Feb 20 23:52:35 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: api: move netinfo update and save one call
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/53760/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 693:         raise ConfigNetworkError(
Line 694:             ne.ERR_BAD_PARAMS, 'Bond %s does not exist' % bond)
Line 695: 
Line 696: 
Line 697: def _net_setup(configurator, networks, bondings, logger, _netinfo):
The first update is needed to be up-to-date before adding the first net.

The last update in the for loop is to keep netinfo up to date after adding a network.

Assuming that netinfo needs to be in sync before leaving this func, I do not see any redundancy here.
Line 698:     connectivity_check_networks = set()
Line 699: 
Line 700:     for network, attrs in networks.iteritems():
Line 701:         if 'remove' in attrs:


-- 
To view, visit https://gerrit.ovirt.org/53760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4dd7572986ffee5a2060470d904116d04e80c97
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list