Change in vdsm[master]: tests: Move network tests to its own folder

nsoffer at redhat.com nsoffer at redhat.com
Sat Feb 20 21:47:00 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: tests: Move network tests to its own folder
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.ovirt.org/#/c/53704/1/tests/Makefile.am
File tests/Makefile.am:

Line 83: 	monkeypatchTests.py \
Line 84: 	momTests.py \
Line 85: 	momPolicyTests.py \
Line 86: 	mountTests.py \
Line 87: 	network/*_test.py \
You should have a Makefile in network, this is how vdsm build system works.

If you want to rewrite it so we have one makefile for the entire tree, you are welcome, but it is not in the scope of moving this patch.
Line 88: 	numaUtilsTests.py \
Line 89: 	outOfProcessTests.py \
Line 90: 	parted_utils_tests.py \
Line 91: 	passwordsTests.py \


https://gerrit.ovirt.org/#/c/53704/1/tests/network/__init__.py
File tests/network/__init__.py:

Line 1: #
Line 2: # Copyright 2013 Red Hat, Inc.
> 2016
Please keep this as empty file.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: from __future__ import absolute_import
We don't have any imports, so this import is not needed.


https://gerrit.ovirt.org/#/c/53704/1/tests/network/net_info_test.py
File tests/network/net_info_test.py:

> i think it should be net_netinfo_test.py
Can you explain the net_ prefix? Why is this needed when we have a package named network/?

I would use the same name as the modules names in vdsm. So if we have the module lib/vdsm/network/foo.py, the test module should be named tests/network/foo_test.py.
Line 1: #
Line 2: # Copyright 2012 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify


-- 
To view, visit https://gerrit.ovirt.org/53704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35031fd50d0451c6321bdf8eee28127422bedafe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list