Change in vdsm[master]: net: api: rename _add_missing_networks -> _net_setup

danken at redhat.com danken at redhat.com
Sat Feb 20 13:56:24 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net: api: rename _add_missing_networks -> _net_setup
......................................................................


Patch Set 1: Code-Review-1

net_setup is a highly-overloaded name (the verb is setupNetworks, we have such a function here).

the function is all about adding networking that are not already defined. so I do not understand the name change.

-- 
To view, visit https://gerrit.ovirt.org/53759
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia08261a4c998a05e16b275fb9cbb5a2386e1937f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list