Change in vdsm[master]: [WIP] net tests: make functional tests run again with persis...

phoracek at redhat.com phoracek at redhat.com
Fri Feb 19 14:51:56 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: [WIP] net tests: make functional tests run again with persistence=ifcfg
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/53713/2/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 249:             _cleanup_qos_definition(reported_qos)
Line 250:             self.assertEqual(reported_qos, hostQos)
Line 251: 
Line 252:         running_config = self.vdsm_net.config
Line 253:         if running_config is None:
i think it would be better to be explicit with

 if not config.get('vars', 'net_persistence') == 'unified':
     continue

 running_config =
 network_config=
Line 254:             return
Line 255: 
Line 256:         network_config = running_config.networks[networkName]
Line 257:         if assert_in_running_conf:


-- 
To view, visit https://gerrit.ovirt.org/53713
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I849172cdab80e760a65ac19d367064b1dbf81b03
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list