Change in vdsm[master]: net: api: don't check for bond slaves twice

danken at redhat.com danken at redhat.com
Fri Feb 19 14:44:32 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: api: don't check for bond slaves twice
......................................................................


net: api: don't check for bond slaves twice

It is not possible to setup bondings via addNetwork() and editNetwork()
calls anymore. Bonds validity checking is now done on setupNetworks()
level on all passed bondings via _validateNetworkSetup() and therefore
extra checking in _handleBondings() (introduced in
https://gerrit.ovirt.org/#/c/37751/8) is now redundant.

Change-Id: I9484ac46963ac0b308d45e1e422f6d2b8b19f8e6
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/53700
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/network/api.py
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/53700
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9484ac46963ac0b308d45e1e422f6d2b8b19f8e6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list