Change in vdsm[master]: virt: Make Vm.devMapFromDevSpecMap() private

mzamazal at redhat.com mzamazal at redhat.com
Fri Feb 19 13:36:23 UTC 2016


Milan Zamazal has uploaded a new change for review.

Change subject: virt: Make Vm.devMapFromDevSpecMap() private
......................................................................

virt: Make Vm.devMapFromDevSpecMap() private

There is currently no reason to expose the method outside Vm.
Actually we are going to move device processing out of Vm and thus
isolating the use of this method is a preparation step for that.

Change-Id: I3a1d8d8d80313a8b4648a255413c26689d1c4657
Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
---
M tests/vmfakelib.py
M vdsm/virt/vm.py
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/53484/4

diff --git a/tests/vmfakelib.py b/tests/vmfakelib.py
index 35a96c0..7fee795 100644
--- a/tests/vmfakelib.py
+++ b/tests/vmfakelib.py
@@ -341,7 +341,7 @@
             fake.guestAgent = GuestAgent()
             fake.conf['devices'] = [] if devices is None else devices
             if create_device_objects:
-                fake._devices = fake.devMapFromDevSpecMap(
+                fake._devices = fake._devMapFromDevSpecMap(
                     fake._devSpecMapFromConf())
             fake._guestCpuRunning = runCpu
             if status is not None:
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 5c77007..a662ab2 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -408,7 +408,7 @@
                 'truesize': 0})
         return removables
 
-    def devMapFromDevSpecMap(self, dev_spec_map):
+    def _devMapFromDevSpecMap(self, dev_spec_map):
         dev_map = self._emptyDevMap()
 
         for dev_type, dev_class in self.DeviceMapping:
@@ -1845,7 +1845,7 @@
             # rebooting it. Evident on, but not limited to, the HE case.
             self._fixLegacyGraphicsConf()
 
-        self._devices = self.devMapFromDevSpecMap(dev_spec_map)
+        self._devices = self._devMapFromDevSpecMap(dev_spec_map)
 
         # We should set this event as a last part of drives initialization
         self._pathsPreparedEvent.set()


-- 
To view, visit https://gerrit.ovirt.org/53484
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a1d8d8d80313a8b4648a255413c26689d1c4657
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list