Change in vdsm[master]: virt: Don't use Vm device configuration in clientIF

mzamazal at redhat.com mzamazal at redhat.com
Fri Feb 19 13:33:56 UTC 2016


Milan Zamazal has posted comments on this change.

Change subject: virt: Don't use Vm device configuration in clientIF
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/53482/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 748:         if drives is None:
        :             drives = self.devSpecMapFromConf()[hwclass.DISK]
> good point. preparePaths() should be public, while devSpecMapFromConf() sho
I like your idea, done.


-- 
To view, visit https://gerrit.ovirt.org/53482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd0f7c99b4df18d27dfad36bf2275540bc8b958c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list