Change in vdsm[master]: migration: added support for setting the convergenceSchedule

fromani at redhat.com fromani at redhat.com
Fri Feb 19 12:57:39 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: migration: added support for setting the convergenceSchedule
......................................................................


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/47734/15/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 7887: #optional actions to perform when stalling
         : #                       The format is a JSON, which consists of two lists:
         : #                       [init, convergence]
         : #                       The init is a list of: [action, [params]]
         : #                       The convergence is a list of:
         : #                       [stalling limit, [action, [params]]]
> badly:
Makes (some) sense. Now that we added type declaration into schema, the Vdsm code (vdsm/rpc/Bridge.py) is able to translate back the wire protocol into Python objects, so we don't need (in theory) to decode using JSON.

Before, we needed this because it was an opaque string, and this sneakiness is exactly what we should change.

Now we need to tune here and there to let Bridge.py do the conversions from schema types to proper python objects. It will involve some try and error I'm afraid. I'll play with the patch and with the jsonrpc client a bit, then suggest some changes.


-- 
To view, visit https://gerrit.ovirt.org/47734
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09818e6f3283880edb704cb77c1f716392b11abe
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list