Change in vdsm[master]: virt: Move most of _getUnderlyingVmDevicesInfo() out of Vm

fromani at redhat.com fromani at redhat.com
Fri Feb 19 08:30:38 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: Move most of _getUnderlyingVmDevicesInfo() out of Vm
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/53679/1/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

Line 792: underlying_devices_info
this is probably the only bit which really belongs to __init__.py.

We generally tend to avoid to add code to __init__.py, so maybe a new module in the vmdevices package?


-- 
To view, visit https://gerrit.ovirt.org/53679
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81a0da783bc40f0f08dfdac2bbb955bc55d81b0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list