Change in vdsm[master]: virt: Most Vm._getUnderlying*() method of core devices moved...

fromani at redhat.com fromani at redhat.com
Fri Feb 19 08:16:15 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: Most Vm._getUnderlying*() method of core devices moved out of Vm
......................................................................


Patch Set 2: Code-Review+1

I'm fairly sure we don't need one getUnderlying* per subclass. A few of them could be generalized. But let's address this in another patch.
Could be worth to split this further, but let's think about this once the (big) patchset is rolling in.

-- 
To view, visit https://gerrit.ovirt.org/53617
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56b742e181eb56db6ccf19a3ab162349be96853e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list