Change in vdsm[master]: net: api: drop isolatedCommand handling

danken at redhat.com danken at redhat.com
Thu Feb 18 16:25:44 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net: api: drop isolatedCommand handling
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/53481/7/tests/configNetworkTests.py
File tests/configNetworkTests.py:

Line 59:     def testAddNetworkValidation(self):
Line 60: 
Line 61:         configurator = api.ConfiguratorClass()
Line 62: 
Line 63:         def _addNetworkWithExc(netName, opts, errCode):
only now did I notice that you've answered my question regarding this move. HOWEVER, improving the performance of the test is not really what this patch is about.

So unless I'm mistaken, and this move is related to the removal of isolatedCommand, please fork it to another patch.
Line 64:             with self.assertRaises(errors.ConfigNetworkError) as cneContext:
Line 65:                 canonize_networks({netName: opts})
Line 66:                 api._addNetwork(netName, configurator, **opts)
Line 67:             self.assertEqual(cneContext.exception.errCode, errCode)


-- 
To view, visit https://gerrit.ovirt.org/53481
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6aa5052eb63a90269bdad8fa543fdb2ef0c8bc7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list