Change in vdsm[master]: net: api: remove bonding handling from _addNetwork

danken at redhat.com danken at redhat.com
Thu Feb 18 16:13:27 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: api: remove bonding handling from _addNetwork
......................................................................


net: api: remove bonding handling from _addNetwork

_addNetwork is not an API verb anymore. setupNetworks API verb
never call _addNetwork to setup a bonding, its nics
and options. Therefore related code should be dropped from
_addNetwork().

Change-Id: I20c79bc8e3d8a0db5e814ad91fa9fcf8ca71be04
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/53475
Reviewed-by: Edward Haas <edwardh at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Continuous-Integration: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/network/api.py
M tests/configNetworkTests.py
2 files changed, 62 insertions(+), 113 deletions(-)

Approvals:
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved; Passed CI tests
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/53475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I20c79bc8e3d8a0db5e814ad91fa9fcf8ca71be04
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list