Change in vdsm[master]: net: api: destroyOnMasterRemoval has stable value

phoracek at redhat.com phoracek at redhat.com
Thu Feb 18 12:10:48 UTC 2016


Petr Horáček has uploaded a new change for review.

Change subject: net: api: destroyOnMasterRemoval has stable value
......................................................................

net: api: destroyOnMasterRemoval has stable value

We don't have to check if 'remove' in attrs, it has been already
done in upper condition.

Change-Id: I09f9833fa867d63b660ba8b1e347e5e2f7a4e2ba
Signed-off-by: Petr Horáček <phoracek at redhat.com>
---
M lib/vdsm/network/api.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/53701/1

diff --git a/lib/vdsm/network/api.py b/lib/vdsm/network/api.py
index c15e4b0..6cd308b 100644
--- a/lib/vdsm/network/api.py
+++ b/lib/vdsm/network/api.py
@@ -646,7 +646,7 @@
             bond = Bond.objectivize(name, configurator, attrs.get('options'),
                                     attrs.get('nics'), mtu=None,
                                     _netinfo=_netinfo,
-                                    destroyOnMasterRemoval='remove' in attrs)
+                                    destroyOnMasterRemoval=True)
             bond.remove()
             _netinfo.del_bonding(name)
         elif name in _netinfo.bondings:
@@ -662,13 +662,13 @@
     for name, attrs in edition:
         bond = Bond.objectivize(name, configurator, attrs.get('options'),
                                 attrs.get('nics'), mtu=None, _netinfo=_netinfo,
-                                destroyOnMasterRemoval='remove' in attrs)
+                                destroyOnMasterRemoval=False)
         logger.debug("Editing bond %r with options %s", bond, bond.options)
         configurator.editBonding(bond, _netinfo)
     for name, attrs in addition:
         bond = Bond.objectivize(name, configurator, attrs.get('options'),
                                 attrs.get('nics'), mtu=None, _netinfo=_netinfo,
-                                destroyOnMasterRemoval='remove' in attrs)
+                                destroyOnMasterRemoval=False)
         logger.debug("Creating bond %r with options %s", bond, bond.options)
         configurator.configureBond(bond)
 


-- 
To view, visit https://gerrit.ovirt.org/53701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09f9833fa867d63b660ba8b1e347e5e2f7a4e2ba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>


More information about the vdsm-patches mailing list