Change in vdsm[master]: net: api: remove bonding handling from _addNetwork
phoracek at redhat.com
phoracek at redhat.com
Thu Feb 18 11:02:26 UTC 2016
Petr Horáček has posted comments on this change.
Change subject: net: api: remove bonding handling from _addNetwork
......................................................................
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/53475/11/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Line 115: :param dhcpv6: whether to use DHCPv6.
Line 116: :param _netinfo: network information snapshot.
Line 117: :param configurator: instance to use to apply the network configuration.
Line 118: :param blockingdhcp: whether to acquire dhcp IP config in a synced manner.
Line 119: :param implicitBonding: whether the bond's existance is tied to it's
> in another patch, we have to change this argument name, together with Bond.
yes, i'm gonna do that in a following patch.
Line 120: master's.
Line 121: :param defaultRoute: Should this network's gateway be set in the main
Line 122: routing table?
Line 123: :param opts: misc options received by the callee, e.g., {'stp': True}. this
Line 416: configurator = ConfiguratorClass()
Line 417:
Line 418: if network not in _netinfo.networks:
Line 419: logging.info("Network %r: doesn't exist in libvirt database", network)
Line 420: _delNonVdsmNetwork(network, vlan, bonding, _netinfo,
> don't you need to pass "nic" here? wouldn't your code explode when the brok
I'll do that in a following patch.
Line 421: configurator)
Line 422: return
Line 423:
Line 424: nics, vlan, vlan_id, bonding = _netinfo.getNicsVlanAndBondingForNetwork(
--
To view, visit https://gerrit.ovirt.org/53475
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20c79bc8e3d8a0db5e814ad91fa9fcf8ca71be04
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list