Change in vdsm[master]: virt: recovery: test: fix typo

danken at redhat.com danken at redhat.com
Thu Feb 18 10:34:51 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: recovery: test: fix typo
......................................................................


virt: recovery: test: fix typo

A typo sneaked in the vdsm.virt.recovery.File.save() method.
It passed by because this code path is seldom exercised, because
is meant to catch a programming error[1].

This patch fixes the typo, and adds a test to prevent it to
happen again.

+++

[1] in a sneaky way, mostly due to backward compatibility
with surrounding code.
The old 3.6.x code just swallowed any error.
Now we have at least a log line.
A better fix would be to explode with exception,
but due to arcane intertwined flows, this may cause havoc.

Change-Id: Ifc0a58758e2878d3c5398e931982d6e193fcd9f1
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/53689
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/vmRecoveryTests.py
M vdsm/virt/recovery.py
2 files changed, 14 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/53689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc0a58758e2878d3c5398e931982d6e193fcd9f1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list