Change in vdsm[master]: contrib: schema converter

vfeenstr at redhat.com vfeenstr at redhat.com
Thu Feb 18 07:50:03 UTC 2016


Vinzenz Feenstra has posted comments on this change.

Change subject: contrib: schema converter
......................................................................


Patch Set 11:

(2 comments)

Instead of reinventing the wheel on the terminology for everything you should really start thinking about using this:

https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md


As an inspiration - Especially for naming etc

Swagger is more REST API oriented and not really good for RPC - However the majority of things are really good and at least have some spec

Our extensions about what VDSM version something was introduced or for what compatibility version is used, is ok to be added, but you even have a different syntax for a lot of things, which I find confusing, please try to follow those specs and modify what is necessary for us.

Thanks.

https://gerrit.ovirt.org/#/c/52864/11/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:

Line 38:         -   defaultvalue: needs updating
Line 39:             description: The amount of memory requested (in KiB)
Line 40:             name: balloon_target
Line 41:             type: string
Line 42:         type: type
object
Line 43: 
Line 44:     BandwidthCurve: &BandwidthCurve
Line 45:         added: '3.6'
Line 46:         description: Bandwidth traffic


Line 147: 
Line 148:         -   description: The physical device name
Line 149:             name: physdev
Line 150:             type: string
Line 151:         type: type
> We have many types and this is just regular type.
this is an object then call it like this, and that shouldn't be params but properties
Line 152: 
Line 153:     IscsiSessionInfo: &IscsiSessionInfo
Line 154:         added: '3.1'
Line 155:         description: Information about a single, active iSCSI session.


-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list