Change in vdsm[master]: py3: modernize network tests

danken at redhat.com danken at redhat.com
Thu Feb 18 07:23:08 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: py3: modernize network tests
......................................................................


Patch Set 1: Code-Review+2 Verified+1

python-modernize had more changes, that I found not required: it replaces "items()" within a list comprehension with list(items()). this is wasteful, and in my opinion - a bug in python-modernize.

-- 
To view, visit https://gerrit.ovirt.org/53594
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9649d786dd6e9d28df2a36a4a6d4496ff560e687
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list