Change in vdsm[master]: net: Fix internal setupNetworks api usage

danken at redhat.com danken at redhat.com
Wed Feb 17 20:46:05 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: Fix internal setupNetworks api usage
......................................................................


net: Fix internal setupNetworks api usage

setupNetworks api defines 2 args and an unlimited number of kwargs.
The code used in the global api to proxy the request to supervdsm used
3 args (the last being a dict).

To be consistent and avoid multipe conversions, setupNetworks definition
should specify 3 args.

This patch is a preperation for removing the bridging that exist at
supervdsm api and exporting setupNetworks api dynamically.

Change-Id: I96e2b7be3251a1c20111034e4cc6a4b746dde269
Signed-off-by: Edward Haas <edwardh at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/53572
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Tested-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/network/api.py
M vdsm/supervdsmServer
M vdsm/vdsm-restore-net-config
3 files changed, 6 insertions(+), 5 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/53572
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I96e2b7be3251a1c20111034e4cc6a4b746dde269
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list