Change in vdsm[master]: contrib: schema converter

nsoffer at redhat.com nsoffer at redhat.com
Thu Feb 18 00:15:14 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: contrib: schema converter
......................................................................


Patch Set 11:

(2 comments)

https://gerrit.ovirt.org/#/c/52864/11/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:

Line 6928:     params:
Line 6929:     -   description: List of secrets to register
Line 6930:         name: secrets
Line 6931:         type:
Line 6932:         - *SecretInfo
This is not very clear compared with the json schema - ['SecretInfo']

We need to rethink how we specify types.
Line 6933: 
Line 6934:     -   defaultvalue: needs updating
Line 6935:         description: If true, unregister other registered secrets
Line 6936:         name: clear


Line 6935:         description: If true, unregister other registered secrets
Line 6936:         name: clear
Line 6937:         type: boolean
Line 6938: 
Line 6939: Host.remove_image_ticket:
Sorting by method name is a complete mess compared with the json schema, were we controlled the sorting.

Maybe we need categories:

    - ImageTickets:
        - Host.add_image_ticket
        - Host.remove_image_ticket
        - ...
    - Secrects
        - Host.registerSecrects
        - Host.unregisterSecrets

Maybe we need to break the Host "class" to smaller classes, but this will break backward compatibility. So I think the best solution for now is to keep the original order of the methods as it was in the json schema.
Line 6940:     added: '4.0'
Line 6941:     description: Stop an image upload data transfer session.
Line 6942:     params:
Line 6943:     -   description: uuid of the ticket to be removed


-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list