Change in vdsm[master]: bridge: obtain method

nsoffer at redhat.com nsoffer at redhat.com
Thu Feb 18 00:00:37 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: bridge: obtain method
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/53472/3/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:

Line 96:         try:
Line 97:             className, methodName = method.split('.', 1)
Line 98:             self.api['commands'][className][methodName]
Line 99:         except (KeyError, ValueError):
Line 100:             raise yajsonrpc.JsonRpcMethodNotFoundError()
Can we include the requested method in the error? It will be hard to debug this when the error does not tell you anything.
Line 101:         return partial(self._dynamicMethod, className, methodName)
Line 102: 
Line 103:     def _convertClassName(self, name):
Line 104:         """


-- 
To view, visit https://gerrit.ovirt.org/53472
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b6cb53d8e42335510e34dfe372c1c21b80ac219
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list