Change in vdsm[master]: schema: inconsistency fixes

fromani at redhat.com fromani at redhat.com
Wed Feb 17 15:09:46 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: schema: inconsistency fixes
......................................................................


Patch Set 3: Code-Review+1

(7 comments)

on virt side looks OK. Please wait for mpolednik crosscheck on a couple of items.

https://gerrit.ovirt.org/#/c/53460/3/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 3020: # Since: 4.15.0
Line 3021: ##
Line 3022: {'type': 'VmGraphicsDevice',
Line 3023:  'data': {'deviceType': 'VmDeviceType', 'device': 'VmGraphicsDeviceType',
Line 3024:           'port': 'uint', '*tlsPort': 'uint',
ok
Line 3025:           'specParams': 'VmGraphicsDeviceSpecParams'}}
Line 3026: 
Line 3027: ##
Line 3028: # @VmSoundDeviceType:


Line 3445: P
ok


Line 3487: ##
Line 3488: {'type': 'VmHostDevice',
Line 3489:  'data': {'deviceType': 'VmDeviceType', 'deviceId': 'UUID',
Line 3490:           'device': 'str', '*bootOrder': 'int',
Line 3491:           '*address': 'VmDeviceAddress', 'alias': 'str',
ok - but Martin, please crosscheck
Line 3492:           '*specParams': 'VmHostDeviceSpecParams'}}
Line 3493: 
Line 3494: ##
Line 3495: # @VmDevice:


Line 3715:           '*numaTune': 'NumaTune', '*guestNumaNodes': ['GuestNumaNode']}}
ok - Martin, please crosscheck this as well since you're tackling Numa.


Line 4343: *totalvfs
this looks unused :\


Line 7347: # Since: 4.10.0
Line 7348: ##
Line 7349: {'type': 'RunningVmStats',
Line 7350:  'data': {'vmId': 'UUID',
Line 7351:           'displayPort': 'uint', '*displaySecurePort': 'uint',
ok
Line 7352:           '*displayType': 'VmDisplayType', '*displayIp': 'str', 'pid': 'uint',
Line 7353:           'vmType': 'VmType', 'kvmEnable': 'bool',
Line 7354:           'network': 'NetworkInterfaceStatsMap',
Line 7355:           'disks': 'VmDiskStatsMap', 'monitorResponse': 'int',


Line 7695:           '*consoleAddress': 'str', '*dstqemu': 'str',
I suspect those are unused - especially dstqemu. Still, this change looks correct, because the code consider them optional, and because what we have in lines 7672 - 7677


-- 
To view, visit https://gerrit.ovirt.org/53460
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95f4f639f3d7de1179f4c77b5267134e88044fd3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list