Change in vdsm[master]: migration: added support for setting the convergenceSchedule

fromani at redhat.com fromani at redhat.com
Wed Feb 17 13:49:33 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: migration: added support for setting the convergenceSchedule
......................................................................


Patch Set 15:

(6 comments)

good direction, but probably the schema changes should go in the parent patch. Please see inline comments (7892) to see why.

https://gerrit.ovirt.org/#/c/47734/15/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 7798: alias
should be 'type' I believe. Let's see if there are close enough examples elsewhere in the schema.


Line 7802: ConvergenceActionWithStallingLimit
a bit too long. Maybe ConvergenceItem?


Line 7809: alias
same: should be 'type'


Line 7815: # List of actions which will be executed before migration starts and list
         : # of actions which will be executed as a reaction to stalling.
in a future patch, could be worth to split in two separate fields?


Line 7820: alias
should be 'type'


Line 7887: #optional actions to perform when stalling
         : #                       The format is a JSON, which consists of two lists:
         : #                       [init, convergence]
         : #                       The init is a list of: [action, [params]]
         : #                       The convergence is a list of:
         : #                       [stalling limit, [action, [params]]]
I think this can now be omitted since the data format could be inferred by the types, which is exactly the reason for the schema updates :)

Please make sure the new schema types don't mess up the schedule when it is passed from Engine to Vdsm.

Previously, it was opaque -thus untouched- by the Vdsm rpc machinery. Now it could be mangled somehow.

Furthermore: the Vdsm rpc code should take care to reconstruct the proper objects (list, tuples, so forth) from the wire protocol, so probably the json.decode we do is now obsolete.


-- 
To view, visit https://gerrit.ovirt.org/47734
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09818e6f3283880edb704cb77c1f716392b11abe
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list