Change in vdsm[master]: net: api: mark functions as private

phoracek at redhat.com phoracek at redhat.com
Wed Feb 17 12:59:46 UTC 2016


Petr Horáček has uploaded a new change for review.

Change subject: net: api: mark functions as private
......................................................................

net: api: mark functions as private

network/api.py functions clientSeen() and assertBridgeClean()
are used only inside network/api.py. Now they are marked with
_ as private.

Change-Id: I0a874999ebfde41e415314bfc88395a077e4753c
Signed-off-by: Petr Horáček <phoracek at redhat.com>
---
M lib/vdsm/network/api.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/53657/1

diff --git a/lib/vdsm/network/api.py b/lib/vdsm/network/api.py
index ae22cc1..24129c8 100644
--- a/lib/vdsm/network/api.py
+++ b/lib/vdsm/network/api.py
@@ -279,7 +279,7 @@
         ipwrapper.linkSet(port, ['mtu', str(mtu)])
 
 
-def assertBridgeClean(bridge, vlan, bonding, nics):
+def _assertBridgeClean(bridge, vlan, bonding, nics):
     ports = set(bridges.ports(bridge))
     ifaces = set(nics)
     if vlan is not None:
@@ -333,7 +333,7 @@
                                      'not all nics enslaved to %s' %
                                      (nics, bonding))
     if bridge_should_be_clean:
-        assertBridgeClean(network, vlan, bonding, nics)
+        _assertBridgeClean(network, vlan, bonding, nics)
 
 
 def _delNonVdsmNetwork(network, vlan, bonding, _netinfo, configurator):
@@ -419,7 +419,7 @@
         configurator.removeQoS(net_ent)
 
 
-def clientSeen(timeout):
+def _clientSeen(timeout):
     start = time.time()
     while timeout >= 0:
         try:
@@ -707,7 +707,7 @@
                         options, logger):
     if utils.tobool(options.get('connectivityCheck', True)):
         logger.debug('Checking connectivity...')
-        if not clientSeen(_get_connectivity_timeout(options)):
+        if not _clientSeen(_get_connectivity_timeout(options)):
             logger.info('Connectivity check failed, rolling back')
             for network in connectivity_check_networks:
                 # If the new added network was created on top of


-- 
To view, visit https://gerrit.ovirt.org/53657
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a874999ebfde41e415314bfc88395a077e4753c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>


More information about the vdsm-patches mailing list