Change in vdsm[master]: migration: Add DynamicThrottling semaphores

fromani at redhat.com fromani at redhat.com
Wed Feb 17 12:58:24 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: migration: Add DynamicThrottling semaphores
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

-1 for visibility of the comments.


I'm kinda torn :)
On one hand, the implementation is nice. We can improve here and there (tests, enforcing the protocol), but seems like a nice start.
On the other hand, we need to address the concerns we already discussed, and to steer from semaphore to queue/resource manager.
Unfortunately, naming and framing matters quite a lot :\

https://gerrit.ovirt.org/#/c/53304/3/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:

Line 209: self.sem._value
better avoid to access private fields (=implementation details) unless we don't really have alternatives


Line 215: self.sem._value
same


https://gerrit.ovirt.org/#/c/53304/3/vdsm/virt/utils.py
File vdsm/virt/utils.py:

Line 237:         # if we are increasing the bound we need to do this outside of
        :         # context manager otherwise release() would deadlock since it also
        :         # tries to obtain the lock
maybe better to enforce this?
I think we can detect when the semaphore is used like context manager and raise in this case.


-- 
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67376d0bd990f89e0a013887cef1a0cb05fb855d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list