Change in vdsm[master]: net: api: remove bonding handling from _addNetwork

phoracek at redhat.com phoracek at redhat.com
Wed Feb 17 11:38:14 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: net: api: remove bonding handling from _addNetwork
......................................................................


Patch Set 8:

(4 comments)

https://gerrit.ovirt.org/#/c/53475/8/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 669
Line 670
Line 671
Line 672
Line 673
> I'm not sure yet if dropping the explicit mtu=None from here is a great ide
Done


Line 87: persistence = _getPersistenceModule()
Line 88: 
Line 89: 
Line 90: def _objectivizeNetwork(bridge=None, vlan=None, vlan_id=None, bonding=None,
Line 91:                         nic=None, mtu=None, ipaddr=None, netmask=None,
> if possible, do not move unrelated args
Done
Line 92:                         gateway=None, bootproto=None, ipv6addr=None,
Line 93:                         ipv6gateway=None, ipv6autoconf=None, dhcpv6=None,
Line 94:                         defaultRoute=None, _netinfo=None, configurator=None,
Line 95:                         blockingdhcp=None, implicitBonding=None, opts=None):


Line 703:     if topNetDev:
Line 704:         topNetDev.remove()
Line 705: 
Line 706: 
Line 707: def _check_bonding_availability(bond, bonds, _netinfo):
> # network's bond must be a newly-built bonds or previously-existing ones
good point, fixed
Line 708:     if bond not in bonds and bond not in _netinfo.bondings:
Line 709:         raise ConfigNetworkError(
Line 710:             ne.ERR_BAD_PARAMS, 'Bond %s does not exist' % bond)
Line 711: 


Line 733:         except ConfigNetworkError as cne:
Line 734:             if cne.errCode == ne.ERR_FAILED_IFUP:
Line 735:                 logger.debug("Adding network %r failed. Running "
Line 736:                              "orphan-devices cleanup", network)
Line 737:                 _emergencyNetworkCleanup(network, attrs, configurator)
> whitespace is not expensive. redundant changes in a diff are.
Done
Line 738:             raise
Line 739: 
Line 740:         _netinfo.updateDevices()  # Things like a bond mtu can change
Line 741: 


-- 
To view, visit https://gerrit.ovirt.org/53475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20c79bc8e3d8a0db5e814ad91fa9fcf8ca71be04
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list