Change in vdsm[master]: virt: vm.py: Make _updateDomainDescriptor() return new XML

fromani at redhat.com fromani at redhat.com
Tue Feb 16 14:17:56 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: vm.py: Make _updateDomainDescriptor() return new XML
......................................................................


Patch Set 1:

Yes, we could probably abandon this direction.

For a future patch, we could evaluate if it is better to have an update() method in DomainDescriptor.

I don't really like the pair

(in Vm class)
   ...
   self.updateDomainDescriptor()
   data = self.domain.xml

somehow feels clunky.

-- 
To view, visit https://gerrit.ovirt.org/53372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic37e3b3eae819a586036dda17021d500f47e4ba7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list