Change in vdsm[master]: vmfex hook: remove filter from directly-attached vnics

osvoboda at redhat.com osvoboda at redhat.com
Tue Feb 16 14:11:20 UTC 2016


Ondřej Svoboda has posted comments on this change.

Change subject: vmfex hook: remove filter from directly-attached vnics
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Modify during iteration, just asking.

https://gerrit.ovirt.org/#/c/53571/2/vdsm_hooks/vmfex_dev/vmfex_vnic.py
File vdsm_hooks/vmfex_dev/vmfex_vnic.py:

Line 136: interface.removeChild(filterElement)
Is it safe to change the parent element (interface) during iteration? I guess it is, and Michael verified functionality, but this is often/generally a bad thing.


-- 
To view, visit https://gerrit.ovirt.org/53571
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47f38a76b06c4d8e8dd14adb7e9c0a1eb6e3ad9e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Anonymous Coward #1001177
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list