Change in vdsm[master]: bridge: obtain method

nsoffer at redhat.com nsoffer at redhat.com
Tue Feb 16 13:56:30 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: bridge: obtain method
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/53472/2/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:

Line 68
Line 69
Line 70
Line 71
Line 72
> The code similar to _dynamicMethod which is wrong and I haven't seen this c
OK, so if is deadcode, can we remove it in a separate patch?


Line 81
Line 82
Line 83
Line 84
Line 85
This looks just like the code you added in the real method few weeks ago, handling any errors.


-- 
To view, visit https://gerrit.ovirt.org/53472
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b6cb53d8e42335510e34dfe372c1c21b80ac219
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list