Change in vdsm[master]: net: Fix internal setupNetworks api usage

edwardh at redhat.com edwardh at redhat.com
Tue Feb 16 12:22:47 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: Fix internal setupNetworks api usage
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/53572/1/vdsm/API.py
File vdsm/API.py:

Line 1502:             self._cif._netConfigDirty = True
Line 1503: 
Line 1504:             with self._rollback() as rollbackCtx:
Line 1505:                 supervdsm.getProxy().setupNetworks(networks, bondings,
Line 1506:                                                    **options)
> this seems wrong, as the public Vdsm API has exactly 3 args. Is there ANY o
setupNetworks is not defined this way, are you suggesting to change it?
"def setupNetworks(networks, bondings, **options)"
Line 1507: 
Line 1508:             if rollbackCtx['status'] != doneCode:
Line 1509:                 _after_network_setup_fail(networks, bondings, options)
Line 1510:             return rollbackCtx


-- 
To view, visit https://gerrit.ovirt.org/53572
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96e2b7be3251a1c20111034e4cc6a4b746dde269
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list